Re: get_order() broken !

[Linus Torvalds]

On Tue, 6 Mar 2007, Benjamin Herrenschmidt wrote:
>
> Ok, maybe I have lots of shit in my eyes.... but it looks like get_order
> in asm-generic/page.h is broken.
> 
> AFAIK, get_order() should round up (and we have code here or there
> assuming such).
> 
> However, it seems to assume that ilog2 rounds up, which it doesn't. It
> rounds down. At least the generic implementation seems to do so and the
> powerpc optimized one too.

Yeah, I think the recent get_order() changes to change it to use ilog2() 
are just crap. I actually looked at it when it went in, but I assumed that 
it had been tested. I don't think it has.

Let's just revert that entirely.

David, quick comments before I undo commit 39d61db0?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/