Re: [PATCH -mm] Blackfin: blackfin i2c driver
From: Wu, Bryan
Date: Wed Mar 07 2007 - 02:39:44 EST
On Tue, 2007-03-06 at 23:14 -0800, Andrew Morton wrote:
> On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare <khali@xxxxxxxxxxxx> wrote:
>
> > > +config BFIN_SDA
> >
> > I2C_BLACKFIN_SDA
>
> The blackfin architecture uses "bfin" pretty much universally, so this
> usage is consistent.
>
> box:/usr/src/25> grep -i blackfin patches/blackfin*|wc -l
> 1608
> box:/usr/src/25> grep -i bfin patches/blackfin*|wc -l
> 6198
>
Thanks for you understanding, but now we want to move to use
CONFIG_BLACKFIN options. There is a new task in our development plan to
change things to CONFIG_BLACKFIN.
At this moment, we both provide CONFIG_BFIN and CONFIG_BLACKFIN. When
all the things relied on CONFIG_BFIN/bfin are changed to
CONFIG_BLACKFIN/blackfin, the CONFIG_BFIN will be removed.
So here I will follow Jean's comments.
> Let's just hope nobody makes a bluefin.
So it is ok for both blackfin and bluefin. But I think Black is cooler
than Blue. -:)
>
> > > + range 0 15 if (BF533 || BF532 || BF531)
> >
> > Trailing whitespace.
>
> I always remove that when merging a patch.
Thanks a lot, could you please give me a script just to kill this
whitespace? So I can do it before sending you patches.
Thanks Jean and Andrew.
-Bryan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/