Re: [PATCH] x86_64 irq: keep consistent for changing IRQ0_VECTOR from 0x20 to 0x30

[Eric W. Biederman]

Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:

> On Mon, 5 Mar 2007, Yinghai Lu wrote:
>>
>> please check the patch
>
> Hmm.. It doesn't look *wrong*, but could you please
>
>  - split it up a bit (some of it is 100% obvious, ie the comment fixes)
>
>  - write an explanation for the individually split up patches
>
>  - not use attachments, but just make it inline. It's practically 
>    impossible to reply and quote part of the patch now.
>
> Eric/Ingo - did you go through and check the patch?

This patch will probably work but I'm against it, as is.

The comment fixes or some variation on them are needed.

But code that assumes we place IRQ0 at a particular place isn't
exactly bad but it is brittle.  If we are to reduce our array size
we can also shave a lot of entries off the top because we mostly use
the high end of the vector range for IPI's.

So if we were to introduce some set of defines of exactly which
vectors we can use and do a thorough job of this I think there may
be something reasonable we can do here.

Unless this makes the code clearer I don't think there is much point
in reducing a fixed sized array from 224 entries to 191 entries, and
it has the potential to make this much less pleasant if we goof up
elsewhere.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/