Re: [PATCH 0/20] x86_64 Relocatable bzImage support (V4)

From: Eric W. Biederman
Date: Wed Mar 07 2007 - 14:10:46 EST


Arjan van de Ven <arjan@xxxxxxxxxxxxx> writes:

> On Wed, 2007-03-07 at 12:27 +0530, Vivek Goyal wrote:
>> Hi,
>>
>> Here is another attempt on x86_64 relocatable bzImage patches(V4). This
>> patchset makes a bzImage relocatable and same kernel binary can be loaded
>> and run from different physical addresses.
>
>
> have these patches been extensively tested with various suspend
> scenarios? (S1,S3,S4 in acpi speak or s2ram and s2disk in Linux speak)

It should be noted what broke was the non-portable constructs in the generic
suspend code.

In particular using __pa() outside of architecture code is not allowed.
Using virt_to_phys() on addresses not part of the kernel's linear mapping is
not generically supported.

text/data are not required to be part of the kernel's linear mapping.

This patchset now causes all code using these non-portable constructs to
fail on x86_64. Which I think is a good thing so we can more easily
spot these kinds of problems.

Patches 15 and 16 appear to make the swpsuspend code rely on portable
constructs. I will let Vivek reply to the amount of testing he has
done in this area.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/