Re: [patch 097/101] revert "drivers/net/tulip/dmfe: support basiccarrier detection"

From: Dan Williams
Date: Wed Mar 07 2007 - 21:41:36 EST


On Wed, 2007-03-07 at 10:14 -0800, Stephen Hemminger wrote:
> On Wed, 07 Mar 2007 09:12:12 -0800
> Greg KH <gregkh@xxxxxxx> wrote:
>
> >
> > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >
> > Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler
> > reports:
> >
> > Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe:
> > support basic carrier detection) breaks networking on my Davicom DM9009.
> > ethtool always reports there is no link. tcpdump shows incoming packets,
> > but TX is disabled. Reverting the above patch fixes the problem.
> >
>
> Carrier detection support is important and should be fixed rather than removed.

Definitely right. If it doesn't work for your card, it needs to be
fixed for your card.

Dan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/