Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

[Pavel Machek]

Hi!

> > > o virt_to_page() call should be used on kernel linear addresses and not
> > >   on kernel text and data addresses. Swsusp code uses it on kernel data
> > >   (statically allocated swsusp_header).
> > > 
> > > o Allocate swsusp_header dynamically so that virt_to_page() can be used
> > >   safely.
> > > 
> > > o I am changing this because in next few patches, __pa() on x86_64 will
> > >   no longer support kernel text and data addresses and hibernation breaks. 
> > > 
> > > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > 
> > (I assume this was tested, too?)
> 
> Yes. I have tested this and it works fine.

ACK from me, then.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/