Re: the usage of DEBUG_DRIVER seems ambiguous

From: Randy Dunlap
Date: Thu Mar 08 2007 - 14:21:18 EST


On Wed, 7 Mar 2007 19:44:41 -0500 (EST) Robert P. J. Day wrote:

>
> the usage of the DEBUG_DRIVER preprocessor variable is a big
> confusing:
>
> $ $ grep -rw DEBUG_DRIVER *
> drivers/net/sunlance.c:#undef DEBUG_DRIVER
> drivers/net/a2065.c:#ifdef DEBUG_DRIVER
> drivers/net/a2065.c:#ifdef DEBUG_DRIVER
> drivers/net/7990.c:#ifdef DEBUG_DRIVER
> drivers/net/7990.c:#ifdef DEBUG_DRIVER
> drivers/base/Kconfig:config DEBUG_DRIVER
> ...
>
> it's clearly a configuration variable, but it's also being used by
> itself in a few drivers/net/ source files. is that deliberate?

The ones in drivers/net/ are just local driver debug controls.
They happen to have the same name as a (likely newer) kconfig symbol.

Is there a real problem that needs to be fixed?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/