Re: [PATCH] Fix building kernel under Solaris

[Jan Engelhardt]

On Mar 8 2007 08:35, Christoph Hellwig wrote:
>On Wed, Mar 07, 2007 at 11:45:11PM +0100, Jan Engelhardt wrote:
>> 
>> On Mar 7 2007 09:42, Christoph Hellwig wrote:
>> >>  #include <sys/time.h>
>> >>  #include <sys/ioctl.h>
>> >>  #include <sys/types.h>
>> >> +#ifndef __sun__
>> >>  #include <asm/types.h>
>> >>  #endif
>> >> +#endif
>> >
>> >So if solaris doesn't need it, why do we need it on Linux?
>> 
>> For __s32 and __s16.
>
>We shouldn't use those from asm/types.h on Linux either, but
>get them consitantly by defining them to the C99 or BSD types
>from the libc headers.

It's a bit icky. file2alias.c includes "../../include/linux/input.h" and it is
_input.h_ that requires __s16/__s32 and hence includes <asm/types.h>.
If you ask me, it's file2alias.c that's broken.


Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/