Re: PAGE_SIZE Availability Inconsistency
From: H. Peter Anvin
Date: Thu Mar 08 2007 - 23:32:56 EST
David Miller wrote:
From: "H. Peter Anvin" <hpa@xxxxxxxxx>
Date: Thu, 08 Mar 2007 20:18:28 -0800
Anton Blanchard wrote:
The other option is to create a v3 swap format that doesnt use any
PAGE_SIZE parameters.
The best thing to do would be to look for the magic both at PAGE_SIZE
(for compatibility) and MIN_PAGE_SIZE (for sanity.)
That might work, but a large part of me says to go for v3
and do it cleanly.
The advantage would be that it wouldn't require a v3 for platforms for
which MIN_PAGE_SIZE == PAGE_SIZE, which accounts for a very large
percentage of systems.
You still have to look for the darn magic in two places, so there is no
reason for it to be different.
-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/