Re: [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.

From: Oliver Neukum
Date: Fri Mar 09 2007 - 03:14:48 EST

Next message: Pekka J Enberg: "[PATCH 2/7] revoke: add f_light flag for struct file"
Previous message: Pekka J Enberg: "[PATCH 1/7] revoke: special mmap handling"
In reply to: Amit Choudhary: "[PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Am Freitag, 9. März 2007 08:18 schrieb Amit Choudhary:
> Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.

No, this is wrong. You must catch this at the source. The driver
cannot function if this function always returns -ENOMEM. It makes
no sense to start up the device under these circumstances.

Regards
Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Pekka J Enberg: "[PATCH 2/7] revoke: add f_light flag for struct file"
Previous message: Pekka J Enberg: "[PATCH 1/7] revoke: special mmap handling"
In reply to: Amit Choudhary: "[PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]