Re: [PATCH 2/7] revoke: add f_light flag for struct file

[Pekka Enberg]

On Fri, Mar 09, 2007 at 12:13:35PM +0100, Eric Dumazet wrote:
> > Then just drop the fget_light() 'optimisation' and always take a reference
> > (atomic on f_count) regardless of single-thread or not. Instead of dirtying
> > f_light, just do the straightforward thing and be with it.
> >
> > (that is : fget_light() = fget() = no more keeping fput_needed everywhere, and
> > convoluted things in some dark sides of the kernel.

On 3/9/07, Benjamin LaHaise <bcrl@xxxxxxxxx> wrote:
> And it makes things rather slower for a lot of single threaded applications
> on modern systems.  Yes, fget_light can be done much more cleanly, but please
> don't go around ripping out optimizations just because.

Don't worry, the fget_light() bits are no longer needed:
http://lkml.org/lkml/2007/3/9/151
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/