Re: Fix locking in mousedev

[Pete Zaitcev]

On Fri, 9 Mar 2007 09:28:49 -0500, "Dmitry Torokhov" <dmitry.torokhov@xxxxxxxxx> wrote:
> On 2/28/07, Pete Zaitcev <zaitcev@xxxxxxxxxx> wrote:

> > Dmitry, please consider getting rid of the list of handles entirely.
> > The other major user is drivers/char/keyboard.c.
> 
> I agree that handlers should not access h_list nad use their own
> private lists instead. However input core still needs that list to
> maintain its books.

Hmm. So it appears that my patch wastes 2 ulongs per input handle
then, in the name of preventing oopses. OK.

> I agree with the patch, unfortunately in lands squarely in the middle
> of me restructuring the code (swiitch to struct device, proper
> refcounting, etc) but I will try to adopt it.

Don't worry about this too much, I can always retest and resubmit,
as long as the main idea is agreeable to you. My users are on RHEL.
Therefore, my main concern is to get something into your tree in
order to avoid this regressing in the future. Meanwhile, users of
our 2.6.9 and 2.6.18 forks get a version of this patch.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/