Re: [PATCH] tick management: make broadcast dependent on local APIC

[Len Brown]

On Saturday 17 February 2007 14:03, Thomas Gleixner wrote:
> The broadcast functionality is only necessary when a local APIC is
> available. Make the config switch depend on X86_LOCAL_APIC. This
> resolves the mach-voyager breakage introduced by the tick managament
> code.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index 1df4a1f..2f76725 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -29,6 +29,7 @@ config GENERIC_CLOCKEVENTS
>  config GENERIC_CLOCKEVENTS_BROADCAST
>  	bool
>  	default y
> +	depends on X86_LOCAL_APIC
>  
>  config LOCKDEP_SUPPORT
>  	bool
> 

Voyager still doesn't build:

arch/i386/kernel/built-in.o: In function `msr_read':
msr.c:(.text+0x8f0d): undefined reference to `smp_call_function_single'
arch/i386/kernel/built-in.o: In function `msr_write':
msr.c:(.text+0x9016): undefined reference to `smp_call_function_single'
arch/i386/kernel/built-in.o: In function `cpuid_read':
cpuid.c:(.text+0x919a): undefined reference to `smp_call_function_single'
arch/i386/lib/built-in.o: In function `wrmsr_on_cpu':
(.text+0x6f): undefined reference to `smp_call_function_single'
arch/i386/lib/built-in.o: In function `rdmsr_on_cpu':
(.text+0xbb): undefined reference to `smp_call_function_single'

Attachment: config.X86_VOYAGER.gz
Description: GNU Zip compressed data