Re: dead(?) header files in the source tree

From: Robert P. J. Day
Date: Sat Mar 10 2007 - 05:13:22 EST


On Sat, 10 Mar 2007, Armin Schindler wrote:

> On Fri, 9 Mar 2007, Robert P. J. Day wrote:
> >
> > following up on an earlier post by stefan richter, i wrote a
> > brute-force little script that scanned the source tree, looking for
> > header files that weren't included from *anywhere* in the tree. what
> > turned up was the following:
> >
> > ./arch/m68k/atari/atasound.h
> > ./arch/arm/mach-s3c2410/bast.h
> > ./arch/ppc/syslib/cpc710.h
> > ./arch/um/kernel/tt/include/mode_kern-tt.h
> > ./arch/powerpc/platforms/83xx/mpc834x_itx.h
> > ./drivers/serial/crisv10.h
> > ./drivers/isdn/hardware/eicon/dbgioctl.h
> > ./drivers/char/digi.h
> > ./drivers/message/i2o/i2o_lan.h
> > ./drivers/net/wan/lmc/lmc_media.h
> > ./drivers/net/skfp/h/lnkstat.h
> > ./drivers/isdn/hardware/eicon/main_if.h
> > ./drivers/message/fusion/lsi/mpi_inb.h
> > ./drivers/message/fusion/lsi/mpi_log_fc.h
> > ./drivers/video/riva/nv4ref.h
> > ./drivers/scsi/pci2000.h
> > ./drivers/char/drm/via_mm.h
> > ./drivers/net/chelsio/vsc8244_reg.h
> > ./include/linux/elfnote.h
> > ./sound/pci/au88x0/au88x0_sb.h
> > ./sound/pci/cs46xx/imgs/cwcemb80.h
> >
> > this list represents an absolute *minimum* of what are apparently
> > orphaned header files, in that they are not referenced from *anywhere
> > else* in the tree, not even from include directives that are
> > currently commented out. in short, they are truly homeless (assuming
> > i didn't screw up my programming, that is).
> >
> > anyone want to get rid of some of them?
>
> Yes. For my part, the file
>
> ./drivers/isdn/hardware/eicon/main_if.h
>
> should be removed.
>
> Shall I write a patch?

sure, feel free.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/