Re: [PATCH] MPT FUSION: Delete unused header files.
From: Robert P. J. Day
Date: Sun Mar 11 2007 - 17:14:46 EST
On Sun, 11 Mar 2007, Eric Moore wrote:
> On Sat, Mar 10, 2007 at 04:57:35PM -0500, Robert P. J. Day wrote:
> >
> > Delete apparently unused header files.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> >
> > ---
> >
> > drivers/message/fusion/lsi/mpi_inb.h | 221 ----------------------
> > drivers/message/fusion/lsi/mpi_log_fc.h | 89 --------
> > 2 files changed, 310 deletions(-)
> >
>
> NACK.
>
> Thanks, but no thanks. Don't remove these header files. These are
> the mpi header files that define the interface between firmware and
> drivers. This set of headers are bundled with each flavor OS, and
> we are constantly providing update files when changes occur.
either way works for me, i was just identifying unused header files.
rday
p.s. just to clarify, when i use the adjective "unused", i mean that
that header file is not used *anywhere* in the source tree -- not even
in an include that is currently commented out or conditionally
included. i mean *nowhere* (as long as i didn't screw up my
programming, that is).
so whether people want to keep those header files in the tree is up to
them.
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/