Re: s2ram still broken with CONFIG_NO_HZ / HPET (macbook pro)

[Tejun Heo]

Soeren Sonnenburg wrote:
> Elsewise I still see the
> 
> ATA: abnormal status 0x80 on port 0x000140df
> ATA: abnormal status 0x80 on port 0x000140df
> ata1.00: configured for UDMA/33
> ata3.01: revalidation failed (errno=-2)
> ata3: failed to recover some devices, retrying in 5 secs
> ATA: abnormal status 0x7F on port 0x000140df
> ATA: abnormal status 0x7F on port 0x000140df
> ata3.01: configured for UDMA/133

I can't tell much about HPET timer, only the ATA messages.

Abnormal messages can be ignored.  Hmmm... revalidation failed without
explaining why.  Can you apply the attached patch and see whether the
added message gets printed?

-- 
tejun
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 14629a3..50a7954 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1484,8 +1484,8 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class,
 				     id, sizeof(id[0]) * ATA_ID_WORDS);
 	if (err_mask) {
 		if (err_mask & AC_ERR_NODEV_HINT) {
-			DPRINTK("ata%u.%d: NODEV after polling detection\n",
-				ap->print_id, dev->devno);
+			ata_dev_printk(dev, KERN_INFO,
+				       "NODEV after polling detection\n");
 			return -ENOENT;
 		}