Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: checkkmalloc() return value.

[David Miller]

From: "Pekka Enberg" <penberg@xxxxxxxxxxxxxx>
Date: Mon, 12 Mar 2007 14:36:46 +0200

> On 3/12/07, Jarek Poplawski <jarkao2@xxxxx> wrote:
> > So, maybe it's less evil to check those NULLs where possible and add
> > some WARN_ONs here and there...
> 
> No, it's much better to oops rather than paper over a bug.

The caller is going to OOPS in this case if you return after an
allocation failure, so there is no improvement after the patch.

Multipath-cached just sucks, it was thrown over the wall by IBM
Germany then never had any followon maintainence at all, so it will be
removed unless someone steps up to seriously maintain and fix that
code, and I REALLY MEAN IT.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/