Re: [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC

[Mikael Pettersson]

Valerie Henson writes:
 > From: Guido Classen <classeng@xxxxxxxx>
 > 
 > This small patch fixes two issues with the Lite-On 82c168 PNIC adapters.
 > I've tested it with two cards in different machines both chip rev 17
 > 
 > The first is the wrong register address CSR6 for writing the MII register
 > which instead is 0xB8 (this may get a symbol too?) (see similar exisiting code
 > at line 437) in tulip_core.c
 > 
 > [Double-checked by Val Henson; yes, 0xB8 is correct register for
 > autonegotiate on this card.]
 > 
 > At least by my cards, the the bit 31 from the MII register seems to be
 > somewhat unstable. This results in reading wrong values from the Phy-Registers
 > und prevents the card from correct initialization. I've added a litte delay
 > and an second test of the bit. If the bit is stil cleared the read/write
 > process has definitely finished.
 > 
 > [Original patch slightly massaged by Val Henson]

Your patch doesn't test for rev 17, so it affects all 82c168 chips.

First, I've been using a rev 32 82c168 for years now in a News
server that's up 24/7, without any issues.

Second, I'm now testing your patch on my rev 32 chip, and so far
it seems to not have caused any regressions.

Just FYI.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/