Re: [QUICKLIST 1/4] Generic quicklist implementation

[Christoph Lameter]

On Tue, 13 Mar 2007, Paul Mundt wrote:

> This doesn't work, and so CONFIG_QUICKLIST is always set. The NR_QUICK
> thing seems a bit backwards anyways, perhaps it would make more sense to
> have architectures set CONFIG_GENERIC_QUICKLIST in the same way that the
> other GENERIC_xxx bits are defined, and then set NR_QUICK based off of
> that. It's obviously going to be 2 or 1 for most people, and x86 seems to
> be the only one that needs 2.

Both i386 and x86_64 currently need 2 and if other arches start using 
quicklists then they would have the same issues. There may be other 
cases in the future where these may be useful. So I think this is too 
inflexible.

> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 7942b33..2f20860 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -163,3 +163,8 @@ config ZONE_DMA_FLAG
>  	default "0" if !ZONE_DMA
>  	default "1"
>  
> +config NR_QUICK
> +	int
> +	depends on GENERIC_QUICKLIST
> +	default "2" if X86
> +	default "1"
> 

Is there a way of checking if a CONFIG_xxx is set to any value?

Then we could do

config QUICKLISTS
	depends on defined(NR_QUICK)

Alternately we could replace #ifdef CONFIG_QUICKLISTS with
#ifdef CONFIG_NR_QUICK ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/