Re: CONFIG_REORDER Kconfig help strange sentence.

[Randy Dunlap]

On Tue, 13 Mar 2007 17:37:35 +1100 Rusty Russell wrote:

> On Tue, 2007-03-13 at 00:56 +0100, Andi Kleen wrote:
> > On Tue, Mar 13, 2007 at 10:18:03AM +1100, Rusty Russell wrote:
> > > OK, this confused me:
> > > 
> > >         Function reordering (REORDER) [N/y/?] (NEW) ?
> > >         
> > >         This option enables the toolchain to reorder functions for a more 
> > >         optimal TLB usage. If you have pretty much any version of binutils, 
> > >         this can increase your kernel build time by roughly one minute.
> > >         
> > > "If you have pretty much any version of binutils"?  Huh?
> > > 
> > > You mean "This will slow your kernel build by about a minute"?
> > 
> > Yes. Lots of sections seem to trigger some quadratic behaviour in ld.
> > 
> > It might be fixed in some unreleased CVS version though (not 100% sure) 
> > 
> > -Andi
> 
> OK, well here is a patch for the moment.
> 
> ==
> Clarify CONFIG_REORDER explanation
> 
> if (1 && X) => if (X).
> 
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> 
> diff -r de5618b5e562 arch/x86_64/Kconfig
> --- a/arch/x86_64/Kconfig	Tue Mar 13 11:41:55 2007 +1100
> +++ b/arch/x86_64/Kconfig	Tue Mar 13 17:27:05 2007 +1100
> @@ -632,8 +632,8 @@ config REORDER
>  	default n
>  	help
>           This option enables the toolchain to reorder functions for a more 
> -         optimal TLB usage. If you have pretty much any version of binutils, 
> -	 this can increase your kernel build time by roughly one minute.
> +         optimal TLB usage.  This will slow your kernel build by
> +	 roughly one minute.

Please consistently use <tab><space><space> for help text.
Yes, it was already mucked up.

>  config K8_NB
>  	def_bool y



---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/