Re: Performance Stats: Kernel patch

[Valdis . Kletnieks]

On Wed, 04 Apr 2007 15:46:24 +0200, Eric Dumazet said:
> On Wed, 04 Apr 2007 17:15:43 +0400
> Maxim Uvarov <muvarov@xxxxxxxxxxxxx> wrote:

> > +#ifdef CONFIG_THREAD_PERF_STAT_SYSC
> > +       call inc_syscallcnt             # Increment syscalls counter 
> > current->sysc_cnt
> > +#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
> 
> Please dont call a function to do one increment !
> 
> You are touching one of the most critical part of the kernel...

Obviously Eric and I looked at this looking for totally different things. :)

Thanks for spotting that, I totally failed to notice that part....

Attachment: pgp00000.pgp
Description: PGP signature