Re: [PATCH 10/10] mm: per device dirty threshold

From: Miklos Szeredi
Date: Tue Apr 24 2007 - 05:49:13 EST


> Ahh, now I see; I had totally blocked out these few lines:
>
> pages_written += write_chunk - wbc.nr_to_write;
> if (pages_written >= write_chunk)
> break; /* We've done our duty */
>
> yeah, those look dubious indeed... And reading back Neil's comments, I
> think he agrees.
>
> Shall we just kill those?

I think we should.

Athough I'm a little afraid, that Akpm will tell me again, that I'm a
stupid git, and that those lines are in fact vitally important ;)

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/