Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.

From: Gerd Hoffmann
Date: Tue Apr 24 2007 - 10:05:37 EST


I get this, across netconsole:

[17179569.184000] console handover: boot [earlyvga_f_0] -> real [tty0]

wanna take a look at why there's cruft in bootconsole->name please?

-EFULL ;)

"earlyvga" is 8 chars. struct console->name is char[8]. No space left for the trailing ´\0´, the cruft comes from the next field (write function pointer). Obviously nobody ever printed the early console names before.

Hmm. We can make the names shorter. We can make the name field longer (probably 16, it ends up taking that much anyway due to aligments at least on 64bit). This looks best to me. We could also use printk("%.8s",name) to make printk stop after 8 chars, but I somehow don't like hardcoding the length like this ...

cheers,
Gerd


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/