Re: [PATCH 06/25] xen: Core Xen implementation
From: Jeremy Fitzhardinge
Date: Wed Apr 25 2007 - 16:03:45 EST
Andi Kleen wrote:
> For me you don't need anymore, but possibly for others.
>
Hm. I'm not a fan of the great big monolithic patch myself, but on the
other hand I don't like the idea of patches which are not self-contained
steps from working->working state. Xen-core.patch is currently the
(more or less) minimal set of stuff which needs to be in place to get
working Xen guest up, and so from that perspective I don't think there's
a good way of splitting it up.
> To summarize the outstanding issues are:
> - fixing sched_clock first
>
What was the sched_clock problem? I don't remember and outstanding
issues with it. I noticed you didn't take paravirt-sched_clock.
> - hopefully more review of the core pieces by others
> - what i commented (minor stuff mostly)
>
I just rebased onto your newest patches, so I'll address your comments
and repost.
> - review of xenbus and drivers
Yes, not much response there.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/