Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs

[Dave Jones]

On Wed, Apr 25, 2007 at 07:21:58PM -0700, Andrew Morton wrote:
 > On Mon, 23 Apr 2007 14:51:29 +0100 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
 > 
 > >  {
 > >  	struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
 > >  
 > > +	pci_dev_put(bridge->dev);
 > >  	agp_remove_bridge(bridge);
 > >  	agp_put_bridge(bridge);
 > > +	pci_dev_put(serverworks_private.svrwrks_dev)
 > > +	serverworks_private.svrwrks_dev = NULL;
 > 
 > err, guys?

? One put for the agp bridge, one for the host bridge.
What am I missing?

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/