Re: [10/17] Variable Order Page Cache: Add clearing and flushingfunction

[Christoph Lameter]

On Tue, 24 Apr 2007, clameter@xxxxxxx wrote:

> +{									\
> +	memset(page_address(__page), (__offset), (__size));		\
> +	flush_mapping_page(__page);					\

This was borked. Dave does this patch make it work?

---
 include/linux/highmem.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.21-rc7/include/linux/highmem.h
===================================================================
--- linux-2.6.21-rc7.orig/include/linux/highmem.h	2007-04-25 23:59:33.000000000 -0700
+++ linux-2.6.21-rc7/include/linux/highmem.h	2007-04-26 00:00:05.000000000 -0700
@@ -88,7 +88,7 @@ static inline void clear_highpage(struct
  */
 #define memclear_highpage_flush(__page,__offset,__size) \
 {									\
-	memset(page_address(__page), (__offset), (__size));		\
+	memset(page_address(__page) + (__offset), 0, (__size));		\
 	flush_mapping_page(__page);					\
 }
 #else
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/