RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

[Jan Beulich]

>>> "Tomita, Haruo" <haruo.tomita@xxxxxxxxxxxxx> 26.04.07 08:56 >>>
>> But why do you remove the printk()?
>
>I think that FWH connected to LPC of ICHx are not only Intel products.
>For example, sst... etc.
>Does rng address differ in except Intel products? 

I am not aware of non-Intel FWHs supporting the same RNG interface.

>I think that this driver is targeting Intel FWH.
>Therefore, printk() was removed.

If you're worried about people thinking their box being reported to have no
FWH when it does, then just make the message say so (i.e. add 82802 or
alike).

># Do you think that a "FWH not detected" message is noisy?

No, I think it helps understanding why there's no RNG device in the system.

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/