Re: W1 printk format warning

From: Andrew Morton
Date: Thu Apr 26 2007 - 17:23:37 EST


On Thu, 26 Apr 2007 22:17:44 +0400 Evgeniy Polyakov <johnpol@xxxxxxxxxxx> wrote:

> On Wed, Apr 25, 2007 at 04:45:09PM -0700, Andrew Morton (akpm@xxxxxxxxxxxxxxxxxxxx) wrote:
> > On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> >
> > > in 2.6.21-rc7-mm1. Are you aware of this?
> > >
> > > drivers/w1/w1.c:460: warning: too few arguments for format
> > >
> > > dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
> > > &sl->dev.bus_id[0]);
> > >
> >
> > Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch added
> > printk arg-checking to dev_dbg() and a bunch of bugs got exposed. I fixed
> > a few of them.
>
> Could you post a full list for w1, if there is only one, here is a fix.
>

There's only the one in w1, I think. I fixed a few more but I didn't
actually go looking for more such errors.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/