Re: MODULE_MAINTAINER

[Krzysztof Halasa]

Rene Herman <rene.herman@xxxxxxxxx> writes:

[MODULE_AUTHOR]

> Given that the email address is all that I want to
> supress; how about just deleting that instead?

Makes sense at least WRT the "problematic" modules.

include/linux/module.h says:

/* Author, ideally of form NAME <EMAIL>[, NAME <EMAIL>]*[ and NAME <EMAIL>] */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

I think we should get rid of the "EMAIL" comments:

/* Author, ideally of form FULL NAME [, FULL NAME ]*[ and FULL NAME] */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)


I'd rather let the respective maintainers/authors take care of "their"
MODULE_AUTHOR entries (though the removal seems sane for me personally).

> I'd prefer that; unlike the name, the adress is information that can
> get outdated

Right

> and moreover, removing the address not only from the
> modinfo output but from the source directly means it can't be mistaken
> for a contact address there either.

Sure.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/