Re: checkpatch, a patch checking script.

[Randy Dunlap]

Matt Mackall wrote:
> On Sun, Apr 29, 2007 at 04:37:01PM -0700, Randy Dunlap wrote:
> > On Sat, 28 Apr 2007 12:21:54 -0500 Matt Mackall wrote:
> >
> > > On Sat, Apr 28, 2007 at 01:11:01PM -0400, Dave Jones wrote:
> > > > On Sat, Apr 28, 2007 at 11:11:36AM -0500, Matt Mackall wrote:
> > > >  > > I'm all ears for additional regexps, bug reports or other suggestions.
> > > >  > 
> > > >  > Neat.
> > > >  > 
> > > >  > Does it check for:
> > > >  > 
> > > >  > functions marked extern?
> > 	data marked extern?
>
> It's perfectly reasonable to have a data extern declaration in a header file.

but it's not perfectly acceptable to have

extern unsigned long volatile jiffies;

in a .c file.

The biggest problem I'm seeing ATM is that this script is a bit too
simplistic.  It doesn't know what it's looking at.  We'll have to
address that, I think.


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/