Re: [patches] [PATCH] [19/40] i386: fix paravirt-documentation

[Jeremy Fitzhardinge]

Nigel Cunningham wrote:
> Hi.
>
> On Mon, 2007-04-30 at 12:27 +0200, Andi Kleen wrote:
>   
>> From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
>> Remove #defines, add enum for PARAVIRT_LAZY_FLUSH.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
>> Signed-off-by: Andi Kleen <ak@xxxxxxx>
>>
>> ---
>>  include/asm-i386/paravirt.h |    7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> ===================================================================
>> Index: linux/include/asm-i386/paravirt.h
>> ===================================================================
>> --- linux.orig/include/asm-i386/paravirt.h
>> +++ linux/include/asm-i386/paravirt.h
>> @@ -30,6 +30,7 @@ enum paravirt_lazy_mode {
>>  	PARAVIRT_LAZY_NONE = 0,
>>  	PARAVIRT_LAZY_MMU = 1,
>>  	PARAVIRT_LAZY_CPU = 2,
>> +	PARAVIRT_LAZY_FLUSH = 3,
>>  };
>>  
>>  struct paravirt_ops
>> @@ -1036,12 +1037,6 @@ static inline pte_t raw_ptep_get_and_cle
>>  }
>>  #endif	/* CONFIG_X86_PAE */
>>  
>> -/* Lazy mode for batching updates / context switch */
>> -#define PARAVIRT_LAZY_NONE 0
>> -#define PARAVIRT_LAZY_MMU  1
>> -#define PARAVIRT_LAZY_CPU  2
>> -#define PARAVIRT_LAZY_FLUSH 3
>> -
>>  #define  __HAVE_ARCH_ENTER_LAZY_CPU_MODE
>>  static inline void arch_enter_lazy_cpu_mode(void)
>>  {
>>     
>
> Is the subject for this right?

Yes.  As part of the documentation I converted the #defines to enums,
but at some point it clashed with the patch which added PARAVIRT_LAZY_FLUSH.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/