Re: [PATCH 06/12] i386: Minimum cpu detection cleanups.

From: H. Peter Anvin
Date: Mon Apr 30 2007 - 12:17:12 EST


Eric W. Biederman wrote:
>
> diff --git a/arch/i386/kernel/verify_cpu.S b/arch/i386/kernel/verify_cpu.S
> index ba9e03e..e51a869 100644
> --- a/arch/i386/kernel/verify_cpu.S
> +++ b/arch/i386/kernel/verify_cpu.S
> @@ -4,10 +4,6 @@
> #include <asm/cpufeature.h>
>
> verify_cpu:
> -#if REQUIRED_MASK1 == 0
> - xorl %eax,%eax
> - ret
> -#endif
> pushfl # Save caller passed flags
> pushl $0 # Kill any dangerous flags
> popfl
> @@ -21,7 +17,7 @@ verify_cpu:
> testl $(1<<18),%eax
^^^^^^^
> jz bad

While you're in there can you change references to the flags to use the
<asm/cpuflags.h> constants?

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/