Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

[Christoph Lameter]

On Sat, 28 Apr 2007, Arjan van de Ven wrote:

> > Hmmm... Yes but that looks like it comes from a different function. Slab
> > calls
> > 
> >  __round_jiffies_relative(HZ, cpu))
> > 
> > And its description says:
> > 
> > /**
> >  *
> >  * The exact rounding is skewed for each processor to avoid all
> >  * processors firing at the exact same time, which could lead
> >  * to lock contention or spurious cache line bouncing.
> 
> 
> > This is exactly the wrong thing to do.
> 
> 
> is it?

Umm you did not read the last bit of the description? It talks about 
firing all timers on all cpus at once.
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/