Re: [4/6] go BUG on vmallocspace in __pa() (was: Re: [-mm patch]i386: enable 4k stacks by default)

From: Alan Cox
Date: Mon Apr 30 2007 - 15:20:18 EST


On Mon, 30 Apr 2007 20:52:42 +0200
Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> On Mon, Apr 30, 2007 at 10:45:10AM -0700, William Lee Irwin III wrote:
> > On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote:
> > > Here's what I did for i386 for someone concerned about blowing the stack.
> >
> > Add checks to __pa() so it goes BUG() on vmallocspace addresses.
>
> Sorry I think that's too costly to do. __pa is pretty common

But not too costly to do if it is done solely with vmalloc the stack for
debug purposes. The bigger problem with the vmalloc approach is there are
still offenders who DMA off the kernel stack on i386 although I'd hope
they are all ancient... we'll find out with this anyway
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/