Re: [patch] cpufreq: do not declare undefined functions

[Dave Jones]

On Mon, Apr 30, 2007 at 12:10:45PM -0700, David Rientjes wrote:
 > On Mon, 30 Apr 2007, Dave Jones wrote:
 > 
 > >  > > it's just a prototype, so no code is generated by declaring one
 > >  > > to an unused (or even non-existant) function.
 > >  > > 
 > >  > > Or are you using some oddball compiler that warns about this?
 > >  > > 
 > >  > 
 > >  > If you consider gcc to be oddball, yes.
 > > 
 > > what version ? Mine doesn't seem to warn on that.
 > > 
 > 4.1.2
 > 
 > arch/i386/kernel/cpu/cpufreq/powernow-k8.h:218: warning: 'fill_powernow_table_pstate' declared 'static' but never defined
 > arch/i386/kernel/cpu/cpufreq/powernow-k8.h:219: warning: 'fill_powernow_table_fidvid' declared 'static' but never defined
 > 
 > Make sure CONFIG_X86_POWERNOW_K8=y and CONFIG_X86_POWERNOW_K8_ACPI=n.

Ah, I had ACPI_PROCESSOR=y, which was flipping it back on after I'd changed it.

Ok. Thanks.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/