Re: [PATCH] ehea: Receive SKB Aggregation

From: Christoph Hellwig
Date: Tue May 08 2007 - 08:16:00 EST


On Tue, May 08, 2007 at 02:05:33PM +0200, Thomas Klein wrote:
> This patch enables the receive side processing to aggregate TCP packets within
> the HEA device driver. It analyses the packets already received after a
> interrupt arrived and forwards these as a chains of SKBs for the same TCP
> connection with modified header field. We have seen a lower CPU load and
> improved throughput for small numbers of parallel TCP connections.
>
> We added a disabled module parameter to prevent disruption of normal driver
> operation.
> We currently consider this as "experimental" until further review and tests
> have been passed.
>
> Are there any concerns about including this in the mainline driver?

So we grow yet another LRO copy in drivers? I think someone needs to
bite the bullet and make it generic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/