Re: Getting make net/built-in.o Error with 2.6.21.1 Build

[Marcel Holtmann]

Hi Jiri,

> > Sure, my aim here was to only solve the _build breakage_ by fixing the 
> > Kconfig for this module (that used code from another kernel module 
> > without listing it in its dependencies). If, as you say, the real 
> > solution is that we should actually be taking out the offending call to 
> > the other module itself, then please go ahead -- I don't know much about 
> > the Bluetooth / HIDP subsytem anyway.
> 
> Converting the hid-ff drivers to be also transport-independent is on my 
> TODO list, but it didn't happen yet.
> 
> Marcel - are you aware of any devices currently supported by USB HID 
> force-feedback code, which have a bluetooth version, please? 

I haven't looked at all details for the PS3 controller, but that might
be the first one. In theory they can and at some point they will enter
the market.

> I'd propose the patch below, until I make the usbhid force-feedback code 
> transport independent. Thanks.
> 
> 
> 
> From: Jiri Kosina <jkosina@xxxxxxx>
> 
> [Bluetooth] HIDP - don't initialize force feedback
> 
> The current implementation of force feedback for HID devices is 
> USB-transport only and therefore calling hid_ff_init() from hidp code is 
> not going to work (plus it creates unwanted dependency of hidp on usbhid). 
> Remove the hid_ff_init() until either the hid-ff is made 
> transport-independent, or at least support for bluetooth transport is 
> added.
> 
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

Under the condition that you remember to put it back once a generic FF
exists.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/