Re: [Linux-fbdev-devel] [PATCH] atmel_lcdfb: AT91/AT32 LCDController framebuffer driver

[Haavard Skinnemoen]

Hi Antonio,

Thanks for the feedback. I'm just going to reply to one of your
comments and leave the rest for Nicolas...

On Tue, 08 May 2007 05:40:17 +0800
"Antonino A. Daplas" <adaplas@xxxxxxxxx> wrote:

> > +static int __init atmel_lcdfb_init(void)
> > +{
> > +	return platform_driver_probe(&atmel_lcdfb_driver, atmel_lcdfb_probe);
> > +}  
> 
> Is this intentional?  Why not platform_driver_register()?

Yes, it's intentional. This way, the atmel_lcdfb_probe function can be
__init since it doesn't need to be referenced from atmel_lcdfb_driver.
Saves a bit of memory at run time.

The downside is that hot plugging won't work, but that isn't very
relevant for on-chip devices anyway.

Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/