Re: [PATCH 1/3] kbuild: complain about missing system calls.

From: Sam Ravnborg
Date: Tue May 08 2007 - 15:11:55 EST


On Tue, May 08, 2007 at 11:35:27AM -0700, Luck, Tony wrote:
> Looks more complex than necessary. Why do you want to execute
> an arch specific script to list the __IGNORE symbols? That would
> allow an arch to generate a list with sed/perl/etc. but that
> looks like overkill.
>
> If you just have an arch specific file with the right defines.
> E.g. for x86_64 in include/asm-x86_64/ignore_syscalls:
>
> #include __IGNORE_getcpu
>
> Then the checksyscalls.sh changes would just be something like
> (do I need a ${srctree} before the include??):
Much better - thanks.

Yes. For "make O=..." builds we need to refer to the file in
the srctree. include/asm/... is not pointing back to the original tree.
So I had to use:

if [ -f ${srctree}/include/asm-${ARCH}/ignore_syscalls ]; then
cat ${srctree}/include/asm-${ARCH}/ignore_syscalls
fi

To make it work.
I will push this change out during the weekend I hope.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/