[2.6.22 PATCH 05/26] dm crypt: fix avoid cloned bio ref after free

From: Alasdair G Kergon
Date: Tue May 08 2007 - 15:45:56 EST


From: olaf.kirch@xxxxxxxxxx

Do not access the bio after generic_make_request

We should never access a bio after generic_make_request - there's
no guarantee it still exists.

Signed-off-by: olaf.kirch@xxxxxxxxxx
Signed-off-by: Alasdair G Kergon <agk@xxxxxxxxxx>
---

drivers/md/dm-crypt.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6.21/drivers/md/dm-crypt.c
===================================================================
--- linux-2.6.21.orig/drivers/md/dm-crypt.c 2007-05-01 17:40:48.000000000 +0100
+++ linux-2.6.21/drivers/md/dm-crypt.c 2007-05-01 17:40:48.000000000 +0100
@@ -655,9 +655,12 @@ static void process_write(struct crypt_i

generic_make_request(clone);

+ /* Do not reference clone after this - it
+ * may be gone already. */
+
/* out of memory -> run queues */
if (remaining)
- congestion_wait(bio_data_dir(clone), HZ/100);
+ congestion_wait(WRITE, HZ/100);
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/