Re: [PATCH 1/2] LogFS proper

From: JÃrn Engel
Date: Tue May 08 2007 - 19:10:17 EST


On Wed, 9 May 2007 00:44:14 +0200, Ingo Oeser wrote:
> On Tuesday 08 May 2007, Thomas Gleixner wrote:
> > On Tue, 2007-05-08 at 00:00 +0200, JÃrn Engel wrote:
> > > +#define packed __attribute__((__packed__))
> >
> > Please use the __attribute__((__packed__)) on your structs instead of
> > creating some extra "needs lookup" magic.
>
> Don't worry, we have __packed predefined for this.
> Just look in include/linux/compiler-gcc.h
>
> I love it, because I always forget at least one brace or undescore level :-)

Cool! Will take that.

JÃrn

--
Audacity augments courage; hesitation, fear.
-- Publilius Syrus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/