Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re:Please pull 'libertas' branch of wireless-2.6)

[Nick Piggin]

Jeff Garzik wrote:
> Nick Piggin wrote:
>
> > Two things on top of a lot of people's pet peeves list are lack of
> > good review bandwidth, and poor driver code! So it is sad this was
> > merged without Christoph's comments being addressed. "it works for
> > me, we can fix it later" is probably a big reason for quality
> > problems of some parts of the kernel.
> >
> > As for Christoph's idea of perfection... it usually isn't a bad
> > thing. And he is quite reasonable if you explain your good reason
> > to disagree or do something differently. The attitude of ignoring
> > comments can be really demotivating for a reviewer.
>
>
> I guess it's a good thing that the maintainer was not ignoring the 
> review comments, then...

My rant was not directed at the driver author...

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/