Re: [GIT PULL] MMC updates

[Nick Piggin]

Pierre Ossman wrote:
> Pierre Ossman wrote:
>
> > Linus, please pull from
> >
> >        git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc.git for-linus
>
>
> fsck! I pushed the wrong branch :/
>
> This fix should have been in the last commit.
>
> Sorry,
>
>
> ------------------------------------------------------------------------
>
> commit 3b9a6d78eb439016728c598a1373b50328f5e9fe
> Author: Pierre Ossman <drzeus@xxxxxxxxx>
> Date:   Wed May 9 07:53:28 2007 +0200
>
>     mmc: fix wrong call to spinlock
>     
>     Fix silly typo in spinlock calls.
>     
>     Signed-off-by: Pierre Ossman <drzeus@xxxxxxxxx>
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index b6c1670..7385acf 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -501,9 +501,9 @@ void mmc_detect_change(struct mmc_host *host, unsigned long delay)
>  {
>  #ifdef CONFIG_MMC_DEBUG
>  	unsigned long flags;
> -	spin_lock_irqsave(host->lock, flags);
> +	spin_lock_irqsave(&host->lock, flags);
>  	BUG_ON(host->removed);
> -	spin_unlock_irqrestore(host->lock, flags);
> +	spin_unlock_irqrestore(&host->lock, flags);
>  #endif

Do you actually need the lock there at all? What is it protecting?

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/