Re: [PATCH 1/2] LogFS proper

From: JÃrn Engel
Date: Wed May 09 2007 - 06:29:01 EST


On Tue, 8 May 2007 17:01:01 -0700, Greg KH wrote:
> On Wed, May 09, 2007 at 01:10:09AM +0200, J??rn Engel wrote:
> >
> > The remaining question is how to deal with kernel-only code that uses
> > be64. Convert that to __be64 as well? Or introduce be64 in
> > include/linix/types.h instead?
>
> I say leave it alone for now, it's not that common :)

Using a fairly lame grep, there are 10k instances versus 60k for u64 and
friends. Sustract about 2.5k used in include/ and possibly part of
userspace interfaces, that leaves about 7.5k.

joern@Galway:/usr/src/kernel/logfs$ sgrep '\<u[136][246]\>' .|wc
60306 313780 3960665
joern@Galway:/usr/src/kernel/logfs$ sgrep '\<__[lb]e[136][246]\>' .|wc
10013 52235 635047
joern@Galway:/usr/src/kernel/logfs$ sgrep '\<__[lb]e[136][246]\>' include|wc
2624 15100 173176

Actually going through them all, the overwhelming majority is used for
structures. I seem to be quite the oddball indeed.

Will change.

JÃrn

--
The grand essentials of happiness are: something to do, something to
love, and something to hope for.
-- Allan K. Chalmers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/