Re: [PATCH 2/2] Call percpu smp cacheline algin interface

[Andrew Morton]

On Mon, 7 May 2007 15:59:44 -0700
Fenghua Yu <fenghua.yu@xxxxxxxxx> wrote:

> On Fri, May 04, 2007 at 05:12:31PM -0700, Fenghua Yu wrote:
> > 
> > Call percpu smp cacheline align interface.
> > 
> 
> This is updated patch. Use new macro name DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED for better code understanding.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Acked-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>

hm, DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED is a bit of a mouthful.

I wonder if we can improve things here so that we use the runtime-detected
cacheline size rather than the compile-time size.  I guess not, given that
the offsets into the percpu area are calculated at build-time.

Did you work out how much space this change will actually save?  It
should be available by suitable crunching on the nm and objdump output.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/