Re: [PATCH] time locale in gen_initramfs_list.sh

From: Andrew Morton
Date: Wed May 09 2007 - 20:10:24 EST


On Tue, 8 May 2007 07:55:26 +0200
Florian Fainelli <florian.fainelli@xxxxxxxxxxx> wrote:

> I noticed that some zsh users who forced their ls formatting to something non
> standard could not generate the initramfs file list. Forcing the locale to C
> while generating seems not to be enough. Adding --time-style=locale will use
> C locale ls output and will let them generate the initramfs list. It has no
> side effects for other users.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxx>
> --
>
>
> [time_locale.patch text/plain (761B)]
> diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh
> index 683eb12..1f96b9b 100644
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -125,7 +125,7 @@ parse() {
> str="${ftype} ${name} ${location} ${str}"
> ;;
> "nod")
> - local dev=`LC_ALL=C ls -l "${location}"`
> + local dev=`LC_ALL=C ls --time-style=locale -l "${location}"`
> local maj=`field 5 ${dev}`
> local min=`field 6 ${dev}`
> maj=${maj%,}
> @@ -135,7 +135,7 @@ parse() {
> str="${ftype} ${name} ${str} ${dev} ${maj} ${min}"
> ;;
> "slink")
> - local target=`field 11 $(LC_ALL=C ls -l "${location}")`
> + local target=`field 11 $(LC_ALL=C ls --time-style=locale -l "${location}")`
> str="${ftype} ${name} ${target} ${str}"
> ;;

hm, --time-style sounds rather gnu-specific and perhaps we'd rather not
add that requirement. Or perhaps we already require gnu ls, dunno.

I'll dump the problem in Sam's lap ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/