Re: remove broken URLs from net drivers' output

[Adrian Bunk]

On Thu, May 10, 2007 at 01:04:24AM +0200, Jesper Juhl wrote:
> On 10/05/07, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>> Linux Kernel Mailing List wrote:
>> > Gitweb:     
>> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
>> > Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
>> > Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
>> > Author:     Markus Dahms <dahms@xxxxxxxxxxxxxxxxx>
>> > AuthorDate: Wed May 9 07:58:10 2007 +0200
>> > Committer:  Adrian Bunk <bunk@xxxxxxxxx>
>> > CommitDate: Wed May 9 08:58:18 2007 +0200
>> >
>> >     remove broken URLs from net drivers' output
>> >
>> >     Remove broken URLs (www.scyld.com) from network drivers' logging 
>> output.
>> >     URLs in comments and other strings are left intact.
>> >
>> >     Signed-off-by: Markus Dahms <dahms@xxxxxxxxxxxxxxxxx>
>> >     Acked-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
>> >     Acked-by: Alan Cox <alan@xxxxxxxxxx>
>> >     igned-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>> > ---
>> >  drivers/net/3c509.c     |    5 ++---
>> >  drivers/net/3c59x.c     |    2 +-
>> >  drivers/net/atp.c       |    8 +++-----
>> >  drivers/net/eepro100.c  |    2 +-
>> >  drivers/net/epic100.c   |   10 ++++------
>> >  drivers/net/natsemi.c   |    1 -
>> >  drivers/net/ne2k-pci.c  |    3 +--
>> >  drivers/net/sundance.c  |    3 +--
>> >  drivers/net/yellowfin.c |    1 -
>> >  9 files changed, 13 insertions(+), 22 deletions(-)
>>
>> Grumble...  This stuff should go through my tree.
>>
>>         Jeff
>>
>
> Note, just for the record; I never explicitly added an Acked-by to
> this patch, I only said in a conversational email that it made sense
> to me...
> I don't actually mind, in this case, to have an Acked-by tagged on
> with my name,  but in general I think that such lines should only be
> added when people explicitly say Acked-by: John Doe, or something like
> "Feel free to add my ACK to this" etc.

Did I miss that "Acked-by:" is considered to be a formal tag like 
"Signed-off-by:"?

I thought it was just an informal tag to mark which people did agree 
with the patch (and the line between your "Makes good sense to me." 
and a "Feel free to add my ACK to this" is really thin).

> Jesper Juhl

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/