Re: [PATCH] Add LZO1X compression support to the kernel

[Richard Purdie]

On Thu, 2007-05-10 at 09:26 +0100, David Woodhouse wrote:
> On Wed, 2007-05-09 at 23:21 -0700, Andrew Morton wrote:
> > Well that's attractive-looking code.
> 
> It's compression code. I've never seen compression code look nice :)
> 
> > Why is this needed?  What code plans to use it?
> 
> I'm itching to use it in JFFS2. Richard claims a 10% boot time speedup
> and 40% improvement on file read speed, with only a slight drop in the
> file compression ratio (when compared to zlib).

Right, the speed improvement is noticeable and useful. JFFS2 is the
primary use case, I've also implemented a crypto interface for it.

> > How many buffer overruns are there in it?
> 
> That I'm afraid I cannot tell you.

There is a "safe" decompression function which does bounds checking so
its at least been thought about by the author. The code has been around
in userspace for a while so hopefully any issues have been ironed out
before now.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/