Re: select is evil: another reason

From: Michael Schmitz
Date: Thu May 10 2007 - 04:58:10 EST


On Wed, 9 May 2007, Russell King wrote:

> drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST'
> drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
> drivers/input/mouse/Kconfig:161:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
>
> The select statements are in generic Kconfig files. The symbols they
> are selecting are in arch-private Kconfig files. Don't do that -
> those symbols are undefined for other architectures.
>
> If you must do that then do:
>
> config ATARI_KBD_CORE
> bool
> + default y if KEYBOARD_ATARI || MOUSE_ATARI
>
> in our m68k Kconfig file, and in arch/powerpc/sysdev/qe_lib/Kconfig:

Will fix. Thanks for reporting this.

Michael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/