Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.

From: Roland Dreier
Date: Thu May 10 2007 - 07:45:48 EST


> CONFIG_MLX4_DEBUG works out to a def_bool y for those that
> have CONFIG_EMBEDDED set. Make it depend on MLX4_CORE..

Thanks, applied... (by the way, this bug just results in an
extraneous CONFIG variable being defined, right? There's no further
breakage -- or am I misunderstanding the situation?)

> I'll let someone else wonder why debugging output is default enabled,
> this seems to be a worrying trend as of late.

Actually this option just controls whether to build the debugging
output at all. The output is controlled at runtime with a module
parameter (which can be changed via sysfs after the module is loaded),
and the output defaults to off.

The reason why I want building the debugging stuff to default to y is
so that distros automatically build modules with debugging enabled.
Otherwise it's a pain to try and gather info from someone who has
problems with a kernel they didn't build.

Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/